Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2108673004:
Enable renderer-side mixing output of different audio sources basing on finch (Closed)
|
Created:
4 years, 5 months ago by o1ka Modified:
4 years, 5 months ago CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable renderer-side mixing output of different audio sources basing on finch
experiment settings
Prerequisite for landing is https://codereview.chromium.org/2067863003
BUG=560378, 622773
Committed: https://crrev.com/80c52cb0f01c3021d076ea9fb71b9981f885b646
Cr-Commit-Position: refs/heads/master@{#403150}
Patch Set 1 #
Total comments: 2
Patch Set 2 : review comment addressed #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Enable renderer-side mixing output of different audio sources basing on finch experiment settings BUG=560378, 622773 ========== to ========== Enable renderer-side mixing output of different audio sources basing on finch experiment settings Prerequisite for landing is https://codereview.chromium.org/2067863003 BUG=560378, 622773 ==========
olka@chromium.org changed reviewers: + grunell@chromium.org
olka@chromium.org changed reviewers: + tommi@chromium.org
PTAL
lgtm
lgtm w/one request https://codereview.chromium.org/2108673004/diff/1/content/renderer/media/audi... File content/renderer/media/audio_device_factory.cc (right): https://codereview.chromium.org/2108673004/diff/1/content/renderer/media/audi... content/renderer/media/audio_device_factory.cc:52: if (base::FeatureList::IsEnabled(media::kNewAudioRenderingMixingStrategy)) return base::FeatureList::IsEnabled(media::kNewAudioRenderingMixingStrategy);
https://codereview.chromium.org/2108673004/diff/1/content/renderer/media/audi... File content/renderer/media/audio_device_factory.cc (right): https://codereview.chromium.org/2108673004/diff/1/content/renderer/media/audi... content/renderer/media/audio_device_factory.cc:52: if (base::FeatureList::IsEnabled(media::kNewAudioRenderingMixingStrategy)) On 2016/06/29 14:03:40, tommi-chrömium wrote: > return base::FeatureList::IsEnabled(media::kNewAudioRenderingMixingStrategy); Done.
The CQ bit was checked by grunell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by olka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from grunell@chromium.org, tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2108673004/#ps20001 (title: "review comment addressed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable renderer-side mixing output of different audio sources basing on finch experiment settings Prerequisite for landing is https://codereview.chromium.org/2067863003 BUG=560378, 622773 ========== to ========== Enable renderer-side mixing output of different audio sources basing on finch experiment settings Prerequisite for landing is https://codereview.chromium.org/2067863003 BUG=560378, 622773 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Enable renderer-side mixing output of different audio sources basing on finch experiment settings Prerequisite for landing is https://codereview.chromium.org/2067863003 BUG=560378, 622773 ========== to ========== Enable renderer-side mixing output of different audio sources basing on finch experiment settings Prerequisite for landing is https://codereview.chromium.org/2067863003 BUG=560378, 622773 Committed: https://crrev.com/80c52cb0f01c3021d076ea9fb71b9981f885b646 Cr-Commit-Position: refs/heads/master@{#403150} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/80c52cb0f01c3021d076ea9fb71b9981f885b646 Cr-Commit-Position: refs/heads/master@{#403150} |
