Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2108673003: PPC/s390: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Reland [heap] Avoid the use of cells to point from code to new-space objects. Port 5e058540192eaf95e8d1c2c3d0920219491cde15 Original commit message: The reason for reverting is: This breaks gc-stress bot: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot Abortion of compaction could cause duplicate entries in the typed-old-to-new remembered set. These duplicates could cause a DCHECK to trigger which checks that slots recorded in the remembered set never point to to-space. This reland-CL allows duplicates in the remembered set by removing the DCHECK, and additionally clears entries in the remembered set if objects are moved. Original issue's description: Cells were needed originally because there was no typed remembered set to record direct pointers from code space to new space. A previous CL (https://codereview.chromium.org/2003553002/) already introduced the remembered set, this CL uses it. This CL * stores direct pointers in code objects, even if the target is in new space, * records the slot of the pointer in typed-old-to-new remembered set, * adds a list which stores weak code-to-new-space references, * adds a test to test-heap.cc for weak code-to-new-space references, * removes prints in tail-call-megatest.js R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/85cebe7389fe47f0efebf0cbb6e71526cc98f94c Cr-Commit-Position: refs/heads/master@{#37346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M src/ppc/assembler-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -13 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/s390/assembler-s390-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-06-28 18:29:51 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-06-28 18:33:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108673003/1
4 years, 5 months ago (2016-06-28 18:34:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 18:56:55 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 18:59:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85cebe7389fe47f0efebf0cbb6e71526cc98f94c
Cr-Commit-Position: refs/heads/master@{#37346}

Powered by Google App Engine
This is Rietveld 408576698