Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Side by Side Diff: src/s390/assembler-s390.cc

Issue 2108673003: PPC/s390: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ppc/macro-assembler-ppc.cc ('k') | src/s390/assembler-s390-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 // ----------------------------------------------------------------------------- 247 // -----------------------------------------------------------------------------
248 // Implementation of Operand and MemOperand 248 // Implementation of Operand and MemOperand
249 // See assembler-s390-inl.h for inlined constructors 249 // See assembler-s390-inl.h for inlined constructors
250 250
251 Operand::Operand(Handle<Object> handle) { 251 Operand::Operand(Handle<Object> handle) {
252 AllowDeferredHandleDereference using_raw_address; 252 AllowDeferredHandleDereference using_raw_address;
253 rm_ = no_reg; 253 rm_ = no_reg;
254 // Verify all Objects referred by code are NOT in new space. 254 // Verify all Objects referred by code are NOT in new space.
255 Object* obj = *handle; 255 Object* obj = *handle;
256 if (obj->IsHeapObject()) { 256 if (obj->IsHeapObject()) {
257 DCHECK(!HeapObject::cast(obj)->GetHeap()->InNewSpace(obj));
258 imm_ = reinterpret_cast<intptr_t>(handle.location()); 257 imm_ = reinterpret_cast<intptr_t>(handle.location());
259 rmode_ = RelocInfo::EMBEDDED_OBJECT; 258 rmode_ = RelocInfo::EMBEDDED_OBJECT;
260 } else { 259 } else {
261 // no relocation needed 260 // no relocation needed
262 imm_ = reinterpret_cast<intptr_t>(obj); 261 imm_ = reinterpret_cast<intptr_t>(obj);
263 rmode_ = kRelocInfo_NONEPTR; 262 rmode_ = kRelocInfo_NONEPTR;
264 } 263 }
265 } 264 }
266 265
267 MemOperand::MemOperand(Register rn, int32_t offset) { 266 MemOperand::MemOperand(Register rn, int32_t offset) {
(...skipping 2812 matching lines...) Expand 10 before | Expand all | Expand 10 after
3080 3079
3081 reloc_info_writer.Write(&rinfo); 3080 reloc_info_writer.Write(&rinfo);
3082 } 3081 }
3083 3082
3084 reloc_info_writer.Finish(); 3083 reloc_info_writer.Finish();
3085 } 3084 }
3086 3085
3087 } // namespace internal 3086 } // namespace internal
3088 } // namespace v8 3087 } // namespace v8
3089 #endif // V8_TARGET_ARCH_S390 3088 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/ppc/macro-assembler-ppc.cc ('k') | src/s390/assembler-s390-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698