Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2108623004: Reland: Refactor contact editor controller into its own class. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Refactor contact editor controller into its own class. Original: http://crrev.com/2092083003 Revert: http://crrev.com/2109573002 Reason for revert: Race condition in test causes assertion failure. Difference in this patch: Fix the race condition in test. The function setTextInEditor() has been replaced with setTextInEditorAndWait(). The editor now notifies the test observer after the text has been updated in a text input field. BUG=603635 Committed: https://crrev.com/b6e380358fdaae4418beed3a34d3098d17532489 Cr-Commit-Position: refs/heads/master@{#402554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -149 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java View 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java View 1 chunk +191 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 8 chunks +32 lines, -116 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 3 chunks +8 lines, -12 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 5 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
please use gerrit instead
dfalcantara@, ptal.
4 years, 5 months ago (2016-06-28 20:10:16 UTC) #2
gone
lgtm
4 years, 5 months ago (2016-06-28 20:46:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108623004/1
4 years, 5 months ago (2016-06-28 20:49:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 21:40:42 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 21:44:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6e380358fdaae4418beed3a34d3098d17532489
Cr-Commit-Position: refs/heads/master@{#402554}

Powered by Google App Engine
This is Rietveld 408576698