chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java - Issue 2108623004: Reland: Refactor contact editor controller into its own class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java

Issue 2108623004: Reland: Refactor contact editor controller into its own class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java

index e07aa3fbc8d33ff564c07d332810f48366013d64..9436e997f99304d6995fe0d45f9e23309003d61f 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java

@@ -50,8 +50,8 @@ public class PaymentRequestIncompleteContactDetailsTest extends PaymentRequestTe

triggerUIAndWait(mReadyForInput);

clickInContactInfoAndWait(R.id.payments_section, mReadyForInput);

clickInContactInfoAndWait(R.id.payments_first_radio_button, mReadyToEdit);

- setTextInEditor(R.id.payments_edit_phone_input, "---");

- setTextInEditor(R.id.payments_edit_email_input, "jane.jones");

+ setTextInEditorAndWait(R.id.payments_edit_phone_input, "---", mEditorTextUpdate);

+ setTextInEditorAndWait(R.id.payments_edit_email_input, "jane.jones", mEditorTextUpdate);

clickInEditorAndWait(R.id.payments_edit_done_button, mEditorValidationError);

clickInEditorAndWait(R.id.payments_edit_cancel_button, mReadyToClose);

clickAndWait(R.id.close_button, mDismissed);

@@ -65,8 +65,9 @@ public class PaymentRequestIncompleteContactDetailsTest extends PaymentRequestTe

triggerUIAndWait(mReadyForInput);

clickInContactInfoAndWait(R.id.payments_section, mReadyForInput);

clickInContactInfoAndWait(R.id.payments_first_radio_button, mReadyToEdit);

- setTextInEditor(R.id.payments_edit_phone_input, "555-555-5555");

- setTextInEditor(R.id.payments_edit_email_input, "jon.doe@google.com");

+ setTextInEditorAndWait(R.id.payments_edit_phone_input, "555-555-5555", mEditorTextUpdate);

+ setTextInEditorAndWait(R.id.payments_edit_email_input, "jon.doe@google.com",

+ mEditorTextUpdate);

clickInEditorAndWait(R.id.payments_edit_done_button, mReadyToPay);

clickAndWait(R.id.button_primary, mReadyForUnmaskInput);

setTextInCardUnmaskDialogAndWait(R.id.card_unmask_input, "123", mReadyToUnmask);