Make lines a special case in GrShape

Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002

Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
Committed: https://skia.googlesource.com/skia/+/0a0f67ececbdf1a7f81296ed0d2cb9e3bc00e4dc

[bsalomon, 2016-06-28 01:36:36]

Description was changed from

==========
Start on making line a GrShape type, need to test degenerate rrects

BUG=skia:
==========

to

==========
Start on making line a GrShape type, need to test degenerate rrects

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
==========

[bsalomon, 2016-06-28 16:39:23]

Description was changed from

==========
Start on making line a GrShape type, need to test degenerate rrects

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
==========

to

==========
Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
==========

[bsalomon, 2016-06-28 16:39:23]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[bsalomon, 2016-06-28 16:39:31]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 16:39:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 16:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 16:44:52]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[bsalomon, 2016-06-28 16:49:29]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 16:49:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-06-28 17:04:05]

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:20: fLineData = that.fLineData;
break here ?!

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:192: fLineData = that.fLineData;
break here ?!

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:412: } else if (fStyle.isDashed()) {
// dashing ignores inverseness
?

[commit-bot: I haz the power, 2016-06-28 17:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 17:05:21]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-06-28 17:09:03]

Patchset #5 (id:80001) has been deleted

[robertphillips, 2016-06-28 17:11:13]

https://codereview.chromium.org/2108523002/diff/60001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2108523002/diff/60001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:1385: 
// A filled line is considered a no-op

?

[bsalomon, 2016-06-28 17:12:50]

Patchset #5 (id:100001) has been deleted

[bsalomon, 2016-06-28 17:13:03]

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:20: fLineData = that.fLineData;
On 2016/06/28 17:04:05, robertphillips wrote:
> break here ?!

Yikes, done.

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:192: fLineData = that.fLineData;
On 2016/06/28 17:04:05, robertphillips wrote:
> break here ?!

Done.

https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:412: } else if (fStyle.isDashed()) {
On 2016/06/28 17:04:05, robertphillips wrote:
> // dashing ignores inverseness
> ?

Done.

[robertphillips, 2016-06-28 17:22:12]

lgtm

[bsalomon, 2016-06-28 17:25:52]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-28 17:25:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 17:41:37]

Description was changed from

==========
Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
==========

to

==========
Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002

Committed:
https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
==========

[commit-bot: I haz the power, 2016-06-28 17:41:40]

Committed patchset #5 (id:120001) as
https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3

[bsalomon, 2016-06-28 18:18:33]

A revert of this CL (patchset #5 id:120001) has been created in
https://codereview.chromium.org/2109613003/ by bsalomon@google.com.

The reason for reverting is: Assertion failures.

[bsalomon, 2016-06-28 18:37:12]

Description was changed from

==========
Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002

Committed:
https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
==========

to

==========
Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002

Committed:
https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
==========

[bsalomon, 2016-06-28 18:37:16]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-06-28 18:37:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2108523002/#ps140001
(title: "reject empty shape in GrDC::internalDrawPath")

[commit-bot: I haz the power, 2016-06-28 18:37:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 18:56:45]

Description was changed from

==========
Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002

Committed:
https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
==========

to

==========
Make lines a special case in GrShape

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002

Committed:
https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
Committed:
https://skia.googlesource.com/skia/+/0a0f67ececbdf1a7f81296ed0d2cb9e3bc00e4dc
==========

[commit-bot: I haz the power, 2016-06-28 18:56:46]

Committed patchset #6 (id:140001) as
https://skia.googlesource.com/skia/+/0a0f67ececbdf1a7f81296ed0d2cb9e3bc00e4dc