Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2108523002: Make lines a special case in GrShape (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : cleanup #

Patch Set 4 : suppress gcc warnings #

Total comments: 7

Patch Set 5 : Address comments #

Patch Set 6 : reject empty shape in GrDC::internalDrawPath #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -48 lines) Patch
M src/gpu/GrDrawContext.cpp View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrShape.h View 10 chunks +40 lines, -8 lines 0 comments Download
M src/gpu/GrShape.cpp View 1 2 3 4 10 chunks +69 lines, -20 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 2 3 9 chunks +128 lines, -14 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
bsalomon
4 years, 5 months ago (2016-06-28 16:39:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108523002/40001
4 years, 5 months ago (2016-06-28 16:39:42 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/9304) Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on ...
4 years, 5 months ago (2016-06-28 16:44:52 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108523002/60001
4 years, 5 months ago (2016-06-28 16:49:32 UTC) #10
robertphillips
https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp File src/gpu/GrShape.cpp (right): https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#newcode20 src/gpu/GrShape.cpp:20: fLineData = that.fLineData; break here ?! https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#newcode192 src/gpu/GrShape.cpp:192: fLineData ...
4 years, 5 months ago (2016-06-28 17:04:05 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 17:05:21 UTC) #13
robertphillips
https://codereview.chromium.org/2108523002/diff/60001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/2108523002/diff/60001/tests/GrShapeTest.cpp#newcode1385 tests/GrShapeTest.cpp:1385: // A filled line is considered a no-op ?
4 years, 5 months ago (2016-06-28 17:11:13 UTC) #15
bsalomon
https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp File src/gpu/GrShape.cpp (right): https://codereview.chromium.org/2108523002/diff/60001/src/gpu/GrShape.cpp#newcode20 src/gpu/GrShape.cpp:20: fLineData = that.fLineData; On 2016/06/28 17:04:05, robertphillips wrote: > ...
4 years, 5 months ago (2016-06-28 17:13:03 UTC) #17
robertphillips
lgtm
4 years, 5 months ago (2016-06-28 17:22:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108523002/120001
4 years, 5 months ago (2016-06-28 17:25:59 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:120001) as https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
4 years, 5 months ago (2016-06-28 17:41:40 UTC) #22
bsalomon
A revert of this CL (patchset #5 id:120001) has been created in https://codereview.chromium.org/2109613003/ by bsalomon@google.com. ...
4 years, 5 months ago (2016-06-28 18:18:33 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108523002/140001
4 years, 5 months ago (2016-06-28 18:37:28 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 18:56:46 UTC) #29
Message was sent while issue was closed.
Committed patchset #6 (id:140001) as
https://skia.googlesource.com/skia/+/0a0f67ececbdf1a7f81296ed0d2cb9e3bc00e4dc

Powered by Google App Engine
This is Rietveld 408576698