Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/gpu/batches/GrDashLinePathRenderer.cpp

Issue 2108523002: Make lines a special case in GrShape (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: reject empty shape in GrDC::internalDrawPath Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/batches/GrAADistanceFieldPathRenderer.cpp ('k') | tests/GrShapeTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "GrDashLinePathRenderer.h" 8 #include "GrDashLinePathRenderer.h"
9 9
10 #include "GrGpu.h" 10 #include "GrGpu.h"
11 #include "GrAuditTrail.h" 11 #include "GrAuditTrail.h"
12 #include "effects/GrDashingEffect.h" 12 #include "effects/GrDashingEffect.h"
13 13
14 bool GrDashLinePathRenderer::onCanDrawPath(const CanDrawPathArgs& args) const { 14 bool GrDashLinePathRenderer::onCanDrawPath(const CanDrawPathArgs& args) const {
15 SkPoint pts[2]; 15 SkPoint pts[2];
16 if (args.fShape->style().isDashed() && args.fShape->asLine(pts)) { 16 bool inverted;
17 if (args.fShape->style().isDashed() && args.fShape->asLine(pts, &inverted)) {
18 // We should never have an inverse dashed case.
19 SkASSERT(!inverted);
17 return GrDashingEffect::CanDrawDashLine(pts, args.fShape->style(), *args .fViewMatrix); 20 return GrDashingEffect::CanDrawDashLine(pts, args.fShape->style(), *args .fViewMatrix);
18 } 21 }
19 return false; 22 return false;
20 } 23 }
21 24
22 bool GrDashLinePathRenderer::onDrawPath(const DrawPathArgs& args) { 25 bool GrDashLinePathRenderer::onDrawPath(const DrawPathArgs& args) {
23 GR_AUDIT_TRAIL_AUTO_FRAME(args.fDrawContext->auditTrail(), 26 GR_AUDIT_TRAIL_AUTO_FRAME(args.fDrawContext->auditTrail(),
24 "GrDashLinePathRenderer::onDrawPath"); 27 "GrDashLinePathRenderer::onDrawPath");
25 bool useHWAA = args.fDrawContext->isUnifiedMultisampled(); 28 bool useHWAA = args.fDrawContext->isUnifiedMultisampled();
26 GrDashingEffect::AAMode aaMode; 29 GrDashingEffect::AAMode aaMode;
27 if (useHWAA) { 30 if (useHWAA) {
28 // We ignore args.fAntiAlias here and force anti aliasing when using MSA A. Otherwise, 31 // We ignore args.fAntiAlias here and force anti aliasing when using MSA A. Otherwise,
29 // we can wind up with external edges antialiased and internal edges una ntialiased. 32 // we can wind up with external edges antialiased and internal edges una ntialiased.
30 aaMode = GrDashingEffect::AAMode::kCoverageWithMSAA; 33 aaMode = GrDashingEffect::AAMode::kCoverageWithMSAA;
31 } else if (args.fAntiAlias) { 34 } else if (args.fAntiAlias) {
32 aaMode = GrDashingEffect::AAMode::kCoverage; 35 aaMode = GrDashingEffect::AAMode::kCoverage;
33 } else { 36 } else {
34 aaMode = GrDashingEffect::AAMode::kNone; 37 aaMode = GrDashingEffect::AAMode::kNone;
35 } 38 }
36 SkPoint pts[2]; 39 SkPoint pts[2];
37 SkAssertResult(args.fShape->asLine(pts)); 40 SkAssertResult(args.fShape->asLine(pts, nullptr));
38 SkAutoTUnref<GrDrawBatch> batch(GrDashingEffect::CreateDashLineBatch(args.fC olor, 41 SkAutoTUnref<GrDrawBatch> batch(GrDashingEffect::CreateDashLineBatch(args.fC olor,
39 *args.f ViewMatrix, 42 *args.f ViewMatrix,
40 pts, 43 pts,
41 aaMode, 44 aaMode,
42 args.fS hape->style())); 45 args.fS hape->style()));
43 if (!batch) { 46 if (!batch) {
44 return false; 47 return false;
45 } 48 }
46 49
47 GrPipelineBuilder pipelineBuilder(*args.fPaint, useHWAA); 50 GrPipelineBuilder pipelineBuilder(*args.fPaint, useHWAA);
48 pipelineBuilder.setUserStencil(args.fUserStencilSettings); 51 pipelineBuilder.setUserStencil(args.fUserStencilSettings);
49 52
50 args.fDrawContext->drawBatch(pipelineBuilder, *args.fClip, batch); 53 args.fDrawContext->drawBatch(pipelineBuilder, *args.fClip, batch);
51 return true; 54 return true;
52 } 55 }
OLDNEW
« no previous file with comments | « src/gpu/batches/GrAADistanceFieldPathRenderer.cpp ('k') | tests/GrShapeTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698