Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2108503008: Merge "Improve performance of HTMLSelectElement::resetToDefaultSelection()." to M52. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge "Improve performance of HTMLSelectElement::resetToDefaultSelection()." to M52. If we remove a selected OPTION from a SELECT element, selectOption() called from resetToDefaultSelection() doesn't need to call deselectItemsWithoutValidation() because there are no other selected OPTIONs. - !multiple() doesn't imply DeselectOtherOptions. Updates existing callsites of selectOption(). - Make SelectOptionFlags mandatory. Removing 20,000 OPTIONs: 6,348ms -> 5,324ms BUG=624220 Review-Url: https://codereview.chromium.org/2110003002 Cr-Commit-Position: refs/heads/master@{#402767} (cherry picked from commit 454e5952a2623d05d272939c01b4b09535be40a3) Committed: https://chromium.googlesource.com/chromium/src/+/6fa87e050f4dcf0b0c54704b6916a0568d496c71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 6 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 5 months ago (2016-07-01 05:57:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6fa87e050f4dcf0b0c54704b6916a0568d496c71.

Powered by Google App Engine
This is Rietveld 408576698