Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2108503008: Merge "Improve performance of HTMLSelectElement::resetToDefaultSelection()." to M52. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 bool isRequiredFormControl() const override; 208 bool isRequiredFormControl() const override;
209 209
210 bool hasPlaceholderLabelOption() const; 210 bool hasPlaceholderLabelOption() const;
211 211
212 enum SelectOptionFlag { 212 enum SelectOptionFlag {
213 DeselectOtherOptions = 1 << 0, 213 DeselectOtherOptions = 1 << 0,
214 DispatchInputAndChangeEvent = 1 << 1, 214 DispatchInputAndChangeEvent = 1 << 1,
215 MakeOptionDirty = 1 << 2, 215 MakeOptionDirty = 1 << 2,
216 }; 216 };
217 typedef unsigned SelectOptionFlags; 217 typedef unsigned SelectOptionFlags;
218 void selectOption(int optionIndex, SelectOptionFlags = 0); 218 void selectOption(int optionIndex, SelectOptionFlags);
219 void selectOption(HTMLOptionElement*, SelectOptionFlags = 0); 219 void selectOption(HTMLOptionElement*, SelectOptionFlags);
220 void selectOption(HTMLOptionElement*, int optionIndex, SelectOptionFlags); 220 void selectOption(HTMLOptionElement*, int optionIndex, SelectOptionFlags);
221 void deselectItemsWithoutValidation(HTMLElement* elementToExclude = 0); 221 void deselectItemsWithoutValidation(HTMLElement* elementToExclude = 0);
222 void parseMultipleAttribute(const AtomicString&); 222 void parseMultipleAttribute(const AtomicString&);
223 HTMLOptionElement* lastSelectedOption() const; 223 HTMLOptionElement* lastSelectedOption() const;
224 void updateSelectedState(HTMLOptionElement*, bool multi, bool shift); 224 void updateSelectedState(HTMLOptionElement*, bool multi, bool shift);
225 void menuListDefaultEventHandler(Event*); 225 void menuListDefaultEventHandler(Event*);
226 void handlePopupOpenKeyboardEvent(Event*); 226 void handlePopupOpenKeyboardEvent(Event*);
227 bool shouldOpenPopupForKeyDownEvent(KeyboardEvent*); 227 bool shouldOpenPopupForKeyDownEvent(KeyboardEvent*);
228 bool shouldOpenPopupForKeyPressEvent(KeyboardEvent*); 228 bool shouldOpenPopupForKeyPressEvent(KeyboardEvent*);
229 void listBoxDefaultEventHandler(Event*); 229 void listBoxDefaultEventHandler(Event*);
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 283
284 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption); 284 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption);
285 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption); 285 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption);
286 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption); 286 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption);
287 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption); 287 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption);
288 }; 288 };
289 289
290 } // namespace blink 290 } // namespace blink
291 291
292 #endif // HTMLSelectElement_h 292 #endif // HTMLSelectElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698