Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2108383002: Fixes crash in PanelLayoutManager (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes crash in PanelLayoutManager During shutdown of sysui I was occasionally crashing in PanelLayoutManager as the window was null. BUG=594600 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/e53dead780ffb90958637c01b1792e53ff3f2081 Cr-Commit-Position: refs/heads/master@{#403020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/wm/panels/panel_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
4 years, 5 months ago (2016-06-29 23:03:36 UTC) #1
James Cook
LGTM
4 years, 5 months ago (2016-06-29 23:20:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108383002/1
4 years, 5 months ago (2016-06-29 23:22:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 00:22:40 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 00:23:00 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 00:25:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e53dead780ffb90958637c01b1792e53ff3f2081
Cr-Commit-Position: refs/heads/master@{#403020}

Powered by Google App Engine
This is Rietveld 408576698