ash/common/wm/panels/panel_layout_manager.cc - Issue 2108383002: Fixes crash in PanelLayoutManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/wm/panels/panel_layout_manager.cc

Issue 2108383002: Fixes crash in PanelLayoutManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/wm/panels/panel_layout_manager.cc

diff --git a/ash/common/wm/panels/panel_layout_manager.cc b/ash/common/wm/panels/panel_layout_manager.cc

index 3c1246ec00fd163a9872450f14fac72237c740fd..0aeb65c388c64adc1455839984e6757b2f9940ae 100644

--- a/ash/common/wm/panels/panel_layout_manager.cc

+++ b/ash/common/wm/panels/panel_layout_manager.cc

@@ -572,7 +572,7 @@ void PanelLayoutManager::RestorePanel(WmWindow* panel) {

}

void PanelLayoutManager::Relayout() {

- if (!shelf_)

+ if (!shelf_ || !shelf_->GetWindow())

return;

// Suppress layouts during overview mode because changing window bounds

« no previous file with comments | « no previous file | no next file » | no next file with comments »