Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2108333002: Notify context element after changes in SVGPreserveAspectRatioTearOff (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify context element after changes in SVGPreserveAspectRatioTearOff Without this the associated LayoutObject will not be notified of the change. TEST=svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html TEST=svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html BUG=231560 Committed: https://crrev.com/bb6f5ff352e1694955be65864b2e78c44fc6235e Cr-Commit-Position: refs/heads/master@{#402960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatioTearOff.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
Revealed by https://codereview.chromium.org/2104943005
4 years, 5 months ago (2016-06-29 21:02:31 UTC) #2
pdr.
On 2016/06/29 at 21:02:31, fs wrote: > Revealed by https://codereview.chromium.org/2104943005 LGTM, nice!
4 years, 5 months ago (2016-06-29 21:04:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108333002/1
4 years, 5 months ago (2016-06-29 21:17:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 22:30:21 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:32:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb6f5ff352e1694955be65864b2e78c44fc6235e
Cr-Commit-Position: refs/heads/master@{#402960}

Powered by Google App Engine
This is Rietveld 408576698