Oilpan: Prepare to move SQLError to oilpan heap.

Oilpan: Prepare to move SQLError to oilpan heap.

Without this CL, a SQLError object can be constructed in a database thread,
moved to main/worker thread, and referred by JavaScript object in the
main/worker thread.

We can't move object ownership over threads in Oilpan. So, we should not
construct SQLError objects in a database thread. Unlike the SQLResultSet case
[1], SQLError is created by multiple classes and it's hard to make sure they
create SQLError in a context thread.

So, this CL introduce SQLErrorData, which is an immutable data container. We can
construct a SQLErrorData object in a database thread, and move it to a context
thread, then construct a SQLError with the SQLErrorData object.

Note:
* Change the return type of AbstractSQLStatementBackend::sqlError from
PassRefPtr<SQLError> to SQLErrorData* because the function doesn't release the
ownership of the SQLErrorData object.

[1] https://src.chromium.org/viewvc/blink?revision=169929&view=revision

BUG=347902
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169989

[tkent, 2014-03-25 09:57:02]

Please review.

[haraken, 2014-03-25 11:50:05]

LGTM

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
File Source/modules/webdatabase/SQLError.h (right):

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLError.h:89: SQLError(const SQLErrorData& data) :
m_code(data.code()), m_message(data.message())

Add 'explicit'.

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLError.h:95: String m_message;

How about making SQLError hold an OwnPtr<SQLErrorData> ? In this CL, m_code and
m_message are duplicated in SQLError and SQLErrorData.

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
File Source/modules/webdatabase/SQLTransaction.cpp (right):

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLTransaction.cpp:178: m_transactionError =
SQLErrorData::create(*m_backend->transactionError());

I think you should add ASSERT(m_backend->transactionError()) instead of the '&&
m_backend->transactionError()' check.

As far as I see the previous code, it's not possible that both
m_transactionError and m_backend->transactionError() are 0.

[wibling-chromium, 2014-03-25 12:16:00]

lgtm

[tkent, 2014-03-25 22:07:13]

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
File Source/modules/webdatabase/SQLError.h (right):

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLError.h:89: SQLError(const SQLErrorData& data) :
m_code(data.code()), m_message(data.message())
On 2014/03/25 11:50:05, haraken wrote:
> 
> Add 'explicit'.

Done.

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLError.h:95: String m_message;
On 2014/03/25 11:50:05, haraken wrote:
> 
> How about making SQLError hold an OwnPtr<SQLErrorData> ? In this CL, m_code
and
> m_message are duplicated in SQLError and SQLErrorData.

Done.

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
File Source/modules/webdatabase/SQLTransaction.cpp (right):

https://codereview.chromium.org/210833005/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLTransaction.cpp:178: m_transactionError =
SQLErrorData::create(*m_backend->transactionError());
On 2014/03/25 11:50:05, haraken wrote:
> 
> I think you should add ASSERT(m_backend->transactionError()) instead of the
'&&
> m_backend->transactionError()' check.
> 
> As far as I see the previous code, it's not possible that both
> m_transactionError and m_backend->transactionError() are 0.

Done.

[tkent, 2014-03-25 22:17:05]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-25 22:17:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/210833005/30001

[commit-bot: I haz the power, 2014-03-25 23:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 23:26:36]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[tkent, 2014-03-25 23:29:18]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-25 23:29:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/210833005/30001

[commit-bot: I haz the power, 2014-03-26 00:34:57]

Change committed as 169989