Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: Source/modules/webdatabase/SQLTransactionBackend.h

Issue 210833005: Oilpan: Prepare to move SQLError to oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: apply comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webdatabase/SQLTransaction.cpp ('k') | Source/modules/webdatabase/SQLTransactionBackend.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/SQLTransactionBackend.h
diff --git a/Source/modules/webdatabase/SQLTransactionBackend.h b/Source/modules/webdatabase/SQLTransactionBackend.h
index cced713b0cd23f1f0b7a2502fce155c331e6afaa..abdd1cf1e46cf2989bd9dfb247c5ee2447f20087 100644
--- a/Source/modules/webdatabase/SQLTransactionBackend.h
+++ b/Source/modules/webdatabase/SQLTransactionBackend.h
@@ -42,7 +42,7 @@ namespace WebCore {
class AbstractSQLTransaction;
class DatabaseBackend;
-class SQLError;
+class SQLErrorData;
class SQLiteTransaction;
class SQLStatementBackend;
class SQLTransactionBackend;
@@ -53,7 +53,7 @@ public:
virtual ~SQLTransactionWrapper() { }
virtual bool performPreflight(SQLTransactionBackend*) = 0;
virtual bool performPostflight(SQLTransactionBackend*) = 0;
- virtual SQLError* sqlError() const = 0;
+ virtual SQLErrorData* sqlError() const = 0;
virtual void handleCommitFailedAfterPostflight(SQLTransactionBackend*) = 0;
};
@@ -78,7 +78,7 @@ private:
// APIs called from the frontend published via AbstractSQLTransactionBackend:
virtual void requestTransitToState(SQLTransactionState) OVERRIDE;
- virtual PassRefPtr<SQLError> transactionError() OVERRIDE;
+ virtual SQLErrorData* transactionError() OVERRIDE;
virtual AbstractSQLStatement* currentStatement() OVERRIDE;
virtual void setShouldRetryCurrentStatement(bool) OVERRIDE;
virtual void executeSQL(PassOwnPtr<AbstractSQLStatement>, const String& statement,
@@ -114,7 +114,7 @@ private:
RefPtrWillBeMember<DatabaseBackend> m_database;
RefPtr<SQLTransactionWrapper> m_wrapper;
- RefPtr<SQLError> m_transactionError;
+ OwnPtr<SQLErrorData> m_transactionError;
bool m_hasCallback;
bool m_hasSuccessCallback;
« no previous file with comments | « Source/modules/webdatabase/SQLTransaction.cpp ('k') | Source/modules/webdatabase/SQLTransactionBackend.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698