Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 210833004: Inform the client when the Service Worker rejects an install event (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebServiceWorkerContextClient.h
diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h
index 540cb061239c36da46c3e21c376eec706843c03c..333b070d6de878a4b3f0c861d5eb5f83b7ac6869 100644
--- a/public/web/WebServiceWorkerContextClient.h
+++ b/public/web/WebServiceWorkerContextClient.h
@@ -79,8 +79,9 @@ public:
// ServiceWorker specific method. Called after InstallEvent (dispatched
// via WebServiceWorkerContextProxy) is handled by the ServiceWorker's
- // script context.
- virtual void didHandleInstallEvent(int installEventID) { }
+ // script context. |rejected| is true if the event handler passed a promise
+ // to waitUntil() that rejected.
+ virtual void didHandleInstallEvent(int installEventID, bool rejected) { }
kinuko 2014/03/25 11:26:51 If you're going to make yet another blink patch (w
falken 2014/03/26 07:26:36 Thanks for the idea. Taking this approach now.
// ServiceWorker specific methods. Called after FetchEvent is handled by the
// ServiceWorker's script context. When no response is provided, the browser

Powered by Google App Engine
This is Rietveld 408576698