Inform the client when the Service Worker rejects an install event

public/web/WebServiceWorkerContextClient.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 61 matching lines @@
 
     // Called when the WorkerGlobalScope had an error or an exception.
     virtual void reportException(const WebString& errorMessage, int lineNumber, int columnNumber, const WebString& sourceURL) { }
 
     // Inspector related messages.
     virtual void dispatchDevToolsMessage(const WebString&) { }
     virtual void saveDevToolsAgentState(const WebString&) { }
 
     // ServiceWorker specific method. Called after InstallEvent (dispatched
     // via WebServiceWorkerContextProxy) is handled by the ServiceWorker's
-    // script context.
-    virtual void didHandleInstallEvent(int installEventID) { }
+    // script context. |rejected| is true if the event handler passed a promise
+    // to waitUntil() that rejected.
+    virtual void didHandleInstallEvent(int installEventID, bool rejected) { }

[kinuko, 2014/03/25 11:26:51]

If you're going to make yet another blink patch (which needs to land before your
first chrome patch) you can include this public interface change code into it
(and probably you can skip the second chrome patch instead)


1st patch (blink): add another virtual void didHandleInstallEvent(...) { } which
internally calls old (single-arg) didHandleInstallEvent()

2nd patch (chrome): implement the new didHandleInstallEvent without disabling
chrome test

3rd patch (blink): remove the old didHandleInstallEvent() interface

[falken, 2014/03/26 07:26:36]

Thanks for the idea. Taking this approach now.

 
     // ServiceWorker specific methods. Called after FetchEvent is handled by the
     // ServiceWorker's script context. When no response is provided, the browser
     // should fallback to native fetch.
     virtual void didHandleFetchEvent(int fetchEventID) { }
     virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse& response) { }
 
     // Ownership of the returned object is transferred to the caller.
     virtual WebServiceWorkerNetworkProvider* createServiceWorkerNetworkProvider(blink::WebDataSource*) { return 0; }
 };
 
 } // namespace blink
 
 #endif // WebWorkerContextClient_h