Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 210823003: Move InterpolationEffect to oilpan's heap (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Move InterpolationEffect to oilpan's heap BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169942

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M Source/core/animation/InterpolationEffect.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M Source/core/animation/InterpolationEffect.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/animation/InterpolationEffectTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-03-25 12:01:07 UTC) #1
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-25 12:06:25 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-25 12:15:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/210823003/20001
6 years, 9 months ago (2014-03-25 12:15:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 12:23:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-25 12:23:27 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-25 12:25:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/210823003/40001
6 years, 9 months ago (2014-03-25 12:25:15 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 13:29:55 UTC) #9
Message was sent while issue was closed. 
Change committed as 169942

Powered by Google App Engine
This is Rietveld 408576698