src/contexts.cc - Issue 2108193003: [modules] AST and parser rework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/contexts.cc

Issue 2108193003: [modules] AST and parser rework. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@anonymous-declarations

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/contexts.cc

diff --git a/src/contexts.cc b/src/contexts.cc

index aa46b4793170a41c755d3f5c8b86f4678c0ba8f8..29f8a5be039e2d833e08576e6911482604bfe228 100644

--- a/src/contexts.cc

+++ b/src/contexts.cc

@@ -203,6 +203,10 @@ static void GetAttributesAndBindingFlags(VariableMode mode,

? BINDING_CHECK_INITIALIZED

: BINDING_IS_INITIALIZED;

break;

+ case IMPORT:

+ *attributes = READ_ONLY;

+ *binding_flags = BINDING_IS_INITIALIZED;

adamk 2016/07/13 18:38:21 Shouldn't this be checking the init_flag? like the

neis 2016/07/14 10:28:23 Need to think about this.

neis 2016/07/15 08:46:32 For now, I'm adding IMPORT to the UNREACHABLE case

+ break;

case DYNAMIC:

case DYNAMIC_GLOBAL:

case DYNAMIC_LOCAL: