[modules] AST and parser rework.

src/contexts.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/contexts.h"
 
 #include "src/ast/scopeinfo.h"
 #include "src/bootstrapper.h"
 #include "src/debug/debug.h"
 #include "src/isolate-inl.h"
@@ skipping 185 matching lines @@
       DCHECK_EQ(kCreatedInitialized, init_flag);
       *attributes = READ_ONLY;
       *binding_flags = BINDING_IS_INITIALIZED;
       break;
     case CONST:
       *attributes = READ_ONLY;
       *binding_flags = (init_flag == kNeedsInitialization)
                            ? BINDING_CHECK_INITIALIZED
                            : BINDING_IS_INITIALIZED;
       break;
+    case IMPORT:
+      *attributes = READ_ONLY;
+      *binding_flags = BINDING_IS_INITIALIZED;

[adamk, 2016/07/13 18:38:21]

Shouldn't this be checking the init_flag? like the other lexical bindings do?

[neis, 2016/07/14 10:28:23]

Need to think about this.

[neis, 2016/07/15 08:46:32]

For now, I'm adding IMPORT to the UNREACHABLE case.

+      break;
     case DYNAMIC:
     case DYNAMIC_GLOBAL:
     case DYNAMIC_LOCAL:
     case TEMPORARY:
       // Note: Fixed context slots are statically allocated by the compiler.
       // Statically allocated variables always have a statically known mode,
       // which is the mode with which they were declared when added to the
       // scope. Thus, the DYNAMIC mode (which corresponds to dynamically
       // declared variables that were introduced through declaration nodes)
       // must not appear here.
@@ skipping 393 matching lines @@
 
   int previous_value = errors_thrown()->value();
   set_errors_thrown(Smi::FromInt(previous_value + 1));
 }
 
 
 int Context::GetErrorsThrown() { return errors_thrown()->value(); }
 
 }  // namespace internal
 }  // namespace v8