Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 210803002: Rename Blink GC plugin flag from detect-cycles to dump-graph. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/tests/cycle_ptrs.flags » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
index f65c52ce4c15573900c0f06f9c00b514a5a8a4d8..59af8e3c8cc60bd95181554142cf782fdcfb3d3f 100644
--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
@@ -111,9 +111,9 @@ const char kDerivesNonStackAllocated[] =
" which is not stack allocated.";
struct BlinkGCPluginOptions {
- BlinkGCPluginOptions() : enable_oilpan(false), detect_cycles(false) {}
+ BlinkGCPluginOptions() : enable_oilpan(false), dump_graph(false) {}
bool enable_oilpan;
- bool detect_cycles;
+ bool dump_graph;
std::set<std::string> ignored_classes;
std::set<std::string> checked_namespaces;
std::vector<std::string> ignored_directories;
@@ -568,7 +568,7 @@ class BlinkGCPluginConsumer : public ASTConsumer {
CollectVisitor visitor;
visitor.TraverseDecl(context.getTranslationUnitDecl());
- if (options_.detect_cycles) {
+ if (options_.dump_graph) {
string err;
// TODO: Make createDefaultOutputFile or a shorter createOutputFile work.
json_ = JsonWriter::from(instance_.createOutputFile(
@@ -1291,8 +1291,8 @@ class BlinkGCPluginAction : public PluginASTAction {
for (size_t i = 0; i < args.size() && parsed; ++i) {
if (args[i] == "enable-oilpan") {
options_.enable_oilpan = true;
- } else if (args[i] == "detect-cycles") {
- options_.detect_cycles = true;
+ } else if (args[i] == "dump-graph") {
+ options_.dump_graph = true;
} else {
parsed = false;
llvm::errs() << "Unknown blink-gc-plugin argument: " << args[i] << "\n";
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/tests/cycle_ptrs.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698