Rename Blink GC plugin flag from detect-cycles to dump-graph.

tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This clang plugin checks various invariants of the Blink garbage
 // collection infrastructure.
 //
 // Errors are described at:
 // http://www.chromium.org/developers/blink-gc-plugin-errors
 
@@ skipping 93 matching lines @@
     "[blink-gc] Field %0 requiring finalization declared here:";
 
 const char kManualDispatchMethodNote[] =
     "[blink-gc] Manual dispatch %0 declared here:";
 
 const char kDerivesNonStackAllocated[] =
     "[blink-gc] Stack-allocated class %0 derives class %1"
     " which is not stack allocated.";
 
 struct BlinkGCPluginOptions {
-  BlinkGCPluginOptions() : enable_oilpan(false), detect_cycles(false) {}
+  BlinkGCPluginOptions() : enable_oilpan(false), dump_graph(false) {}
   bool enable_oilpan;
-  bool detect_cycles;
+  bool dump_graph;
   std::set<std::string> ignored_classes;
   std::set<std::string> checked_namespaces;
   std::vector<std::string> ignored_directories;
 };
 
 typedef std::vector<CXXRecordDecl*> RecordVector;
 typedef std::vector<CXXMethodDecl*> MethodVector;
 
 // Test if a template specialization is an instantiation.
 static bool IsTemplateInstantiation(CXXRecordDecl* record) {
@@ skipping 434 matching lines @@
     diag_overridden_non_virtual_trace_note_ = diagnostic_.getCustomDiagID(
         DiagnosticsEngine::Note, kOverriddenNonVirtualTraceNote);
     diag_manual_dispatch_method_note_ = diagnostic_.getCustomDiagID(
         DiagnosticsEngine::Note, kManualDispatchMethodNote);
   }
 
   virtual void HandleTranslationUnit(ASTContext& context) {
     CollectVisitor visitor;
     visitor.TraverseDecl(context.getTranslationUnitDecl());
 
-    if (options_.detect_cycles) {
+    if (options_.dump_graph) {
       string err;
       // TODO: Make createDefaultOutputFile or a shorter createOutputFile work.
       json_ = JsonWriter::from(instance_.createOutputFile(
           "",                                      // OutputPath
           err,                                     // Errors
           true,                                    // Binary
           true,                                    // RemoveFileOnSignal
           instance_.getFrontendOpts().OutputFile,  // BaseInput
           "graph.json",                            // Extension
           false,                                   // UseTemporary
@@ skipping 702 matching lines @@
     return new BlinkGCPluginConsumer(instance, options_);
   }
 
   virtual bool ParseArgs(const CompilerInstance& instance,
                          const std::vector<string>& args) {
     bool parsed = true;
 
     for (size_t i = 0; i < args.size() && parsed; ++i) {
       if (args[i] == "enable-oilpan") {
         options_.enable_oilpan = true;
-      } else if (args[i] == "detect-cycles") {
-        options_.detect_cycles = true;
+      } else if (args[i] == "dump-graph") {
+        options_.dump_graph = true;
       } else {
         parsed = false;
         llvm::errs() << "Unknown blink-gc-plugin argument: " << args[i] << "\n";
       }
     }
 
     return parsed;
   }
 
  private:
   BlinkGCPluginOptions options_;
 };
 
 }  // namespace
 
 static FrontendPluginRegistry::Add<BlinkGCPluginAction> X(
     "blink-gc-plugin",
     "Check Blink GC invariants");