Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 210803002: Rename Blink GC plugin flag from detect-cycles to dump-graph. (Closed)

Created:
6 years, 9 months ago by zerny-chromium
Modified:
6 years, 9 months ago
CC:
chromium-reviews, oilpan-reviews
Visibility:
Public.

Description

Rename Blink GC plugin flag from detect-cycles to dump-graph. BUG=334149 R=ager@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_ptrs.flags View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_sub.flags View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_super.flags View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_super_neg.flags View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
zerny-chromium
6 years, 9 months ago (2014-03-25 07:41:05 UTC) #1
Mads Ager (chromium)
lgtm
6 years, 9 months ago (2014-03-25 09:02:23 UTC) #2
haraken
LGTM.
6 years, 9 months ago (2014-03-25 09:07:33 UTC) #3
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-25 09:44:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/210803002/1
6 years, 9 months ago (2014-03-25 09:44:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 11:12:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-25 11:12:19 UTC) #7
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-25 11:56:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/210803002/1
6 years, 9 months ago (2014-03-25 11:56:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/210803002/1
6 years, 9 months ago (2014-03-25 12:54:18 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 16:29:36 UTC) #11
Message was sent while issue was closed.
Change committed as 259231

Powered by Google App Engine
This is Rietveld 408576698