Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2107953002: gin: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gin: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=jochen, danakj, dcheng BUG=554600 Committed: https://crrev.com/1ee03c4c04b838817fd89a9c384facf40a289dae Cr-Commit-Position: refs/heads/master@{#403300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M gin/v8_isolate_memory_dump_provider.cc View 7 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:22:08 UTC) #1
danakj
LGTM
4 years, 5 months ago (2016-06-28 22:15:52 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-29 15:18:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107953002/1
4 years, 5 months ago (2016-06-30 20:38:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 21:41:18 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:42:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ee03c4c04b838817fd89a9c384facf40a289dae
Cr-Commit-Position: refs/heads/master@{#403300}

Powered by Google App Engine
This is Rietveld 408576698