Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: gin/v8_isolate_memory_dump_provider.cc

Issue 2107953002: gin: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/v8_isolate_memory_dump_provider.cc
diff --git a/gin/v8_isolate_memory_dump_provider.cc b/gin/v8_isolate_memory_dump_provider.cc
index c501ed5a1e6fea655d615bfbd073a6ca1c08fa5f..601937b45f0a2820b0789c14a90263016df9448b 100644
--- a/gin/v8_isolate_memory_dump_provider.cc
+++ b/gin/v8_isolate_memory_dump_provider.cc
@@ -112,7 +112,8 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
std::string space_dump_name =
space_name_prefix + "/" + space_statistics.space_name();
- auto space_dump = process_memory_dump->CreateAllocatorDump(space_dump_name);
+ auto* space_dump =
+ process_memory_dump->CreateAllocatorDump(space_dump_name);
space_dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
base::trace_event::MemoryAllocatorDump::kUnitsBytes,
space_physical_size);
@@ -128,7 +129,8 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
// Compute the rest of the memory, not accounted by the spaces above.
std::string other_spaces_name = space_name_prefix + "/other_spaces";
- auto other_dump = process_memory_dump->CreateAllocatorDump(other_spaces_name);
+ auto* other_dump =
+ process_memory_dump->CreateAllocatorDump(other_spaces_name);
other_dump->AddScalar(
base::trace_event::MemoryAllocatorDump::kNameSize,
@@ -148,7 +150,7 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
// so we add an extra dump to avoid mismatches w.r.t. the total
// resident values.
if (heap_statistics.does_zap_garbage()) {
- auto zap_dump = process_memory_dump->CreateAllocatorDump(
+ auto* zap_dump = process_memory_dump->CreateAllocatorDump(
dump_base_name + "/zapped_for_debug");
zap_dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
base::trace_event::MemoryAllocatorDump::kUnitsBytes,
@@ -158,7 +160,7 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
// Dump statistics about malloced memory.
std::string malloc_name = dump_base_name + "/malloc";
- auto malloc_dump = process_memory_dump->CreateAllocatorDump(malloc_name);
+ auto* malloc_dump = process_memory_dump->CreateAllocatorDump(malloc_name);
malloc_dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
base::trace_event::MemoryAllocatorDump::kUnitsBytes,
heap_statistics.malloced_memory());
@@ -172,7 +174,7 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
// Add an empty row for the heap_spaces. This is to keep the shape of the
// dump stable, whether code stats are enabled or not.
- auto heap_spaces_dump =
+ auto* heap_spaces_dump =
process_memory_dump->CreateAllocatorDump(space_name_prefix);
// Dump object statistics only for detailed dumps.
@@ -198,7 +200,7 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
object_name_prefix + "/" + object_statistics.object_type();
if (object_statistics.object_sub_type()[0] != '\0')
dump_name += std::string("/") + object_statistics.object_sub_type();
- auto object_dump = process_memory_dump->CreateAllocatorDump(dump_name);
+ auto* object_dump = process_memory_dump->CreateAllocatorDump(dump_name);
object_dump->AddScalar(
base::trace_event::MemoryAllocatorDump::kNameObjectCount,
@@ -212,9 +214,9 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
if (process_memory_dump->GetAllocatorDump(object_name_prefix +
"/CODE_TYPE")) {
- auto code_kind_dump = process_memory_dump->CreateAllocatorDump(
+ auto* code_kind_dump = process_memory_dump->CreateAllocatorDump(
object_name_prefix + "/CODE_TYPE/CODE_KIND");
- auto code_age_dump = process_memory_dump->CreateAllocatorDump(
+ auto* code_age_dump = process_memory_dump->CreateAllocatorDump(
object_name_prefix + "/CODE_TYPE/CODE_AGE");
process_memory_dump->AddOwnershipEdge(code_kind_dump->guid(),
code_age_dump->guid());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698