Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2107933002: Fix dependency issue in content_common (gyp) (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
Reviewers:
Nate Chapin, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2782
Target Ref:
refs/pending/branch-heads/2782
Project:
chromium
Visibility:
Public.

Description

Fix dependency issue in content_common (gyp) content/public/common/common_param_traits_macros.h includes a generated header from blink.gyp:mojo_bindings. This means anyone that depends upon content_common must also depend upon blink.gyp:mojo_bindings, otherwise the header may not have been generated and you get a compile error. The gn build deals with this already by using public_deps. BUG=622365 TEST=build only change R=jam@chromium.org, japhet@chromium.org Review-Url: https://codereview.chromium.org/2102183002 Cr-Commit-Position: refs/heads/master@{#402538} (cherry picked from commit 5f535f591cfafe8887d6a718eef1ef6124376637) Committed: https://chromium.googlesource.com/chromium/src/+/b56c3456420169cb81c1b08c44372fa4e1c29325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/content_common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
4 years, 5 months ago (2016-06-28 20:56:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b56c3456420169cb81c1b08c44372fa4e1c29325.

Powered by Google App Engine
This is Rietveld 408576698