Chromium Code Reviews
DescriptionFix dependency issue in content_common (gyp)
content/public/common/common_param_traits_macros.h includes a
generated header from blink.gyp:mojo_bindings. This means anyone that
depends upon content_common must also depend upon
blink.gyp:mojo_bindings, otherwise the header may not have been
generated and you get a compile error.
The gn build deals with this already by using public_deps.
BUG=622365
TEST=build only change
R=jam@chromium.org, japhet@chromium.org
Review-Url: https://codereview.chromium.org/2102183002
Cr-Commit-Position: refs/heads/master@{#402538}
(cherry picked from commit 5f535f591cfafe8887d6a718eef1ef6124376637)
Committed: https://chromium.googlesource.com/chromium/src/+/b56c3456420169cb81c1b08c44372fa4e1c29325
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||