Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2102183002: Fix dependency issue in content_common (gyp) (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
stevenjb, Nate Chapin, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, Greg Levin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dependency issue in content_common (gyp) content/public/common/common_param_traits_macros.h includes a generated header from blink.gyp:mojo_bindings. This means anyone that depends upon content_common must also depend upon blink.gyp:mojo_bindings, otherwise the header may not have been generated and you get a compile error. The gn build deals with this already by using public_deps. BUG=622365 TEST=build only change R=jam@chromium.org, japhet@chromium.org Committed: https://crrev.com/5f535f591cfafe8887d6a718eef1ef6124376637 Cr-Commit-Position: refs/heads/master@{#402538}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/content_common.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
sky
japhet: blink jam: content
4 years, 5 months ago (2016-06-28 19:46:36 UTC) #4
Nate Chapin
lgtm
4 years, 5 months ago (2016-06-28 19:48:10 UTC) #5
stevenjb
Thanks for figuring this out! +glevin@ FYI
4 years, 5 months ago (2016-06-28 19:59:20 UTC) #7
jam
lgtm
4 years, 5 months ago (2016-06-28 20:26:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102183002/20001
4 years, 5 months ago (2016-06-28 20:30:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102183002/20001
4 years, 5 months ago (2016-06-28 20:33:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 20:40:11 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:41:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f535f591cfafe8887d6a718eef1ef6124376637
Cr-Commit-Position: refs/heads/master@{#402538}

Powered by Google App Engine
This is Rietveld 408576698