Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2107833002: [turbofan] Allow stores bigger than tagged size in store-store elimination. (Closed)

Created:
4 years, 5 months ago by bgeron
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow stores bigger than tagged size in store-store elimination. BUG= Committed: https://crrev.com/2652812b642f39cdfbe91ca9e0ddfbebdb9d44f8 Cr-Commit-Position: refs/heads/master@{#37374}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename functions as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -60 lines) Patch
M src/compiler/store-store-elimination.cc View 1 5 chunks +105 lines, -48 lines 0 comments Download
M src/machine-type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/machine-type.cc View 1 chunk +15 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
bgeron
PTAL.
4 years, 5 months ago (2016-06-28 16:54:25 UTC) #2
bgeron
See the dependent patchset for try results.
4 years, 5 months ago (2016-06-28 16:56:20 UTC) #3
bgeron
Tests succeed for Optdebug on x64 and ia32 on my machine. (Contrary to https://codereview.chromium.org/2099683002/#ps1)
4 years, 5 months ago (2016-06-28 16:57:02 UTC) #4
Jarin
lgtm. Thanks! https://codereview.chromium.org/2107833002/diff/1/src/compiler/store-store-elimination.cc File src/compiler/store-store-elimination.cc (right): https://codereview.chromium.org/2107833002/diff/1/src/compiler/store-store-elimination.cc#newcode210 src/compiler/store-store-elimination.cc:210: bool LeqTagged(FieldAccess access) { How about AtMostTagged ...
4 years, 5 months ago (2016-06-28 21:30:55 UTC) #5
bgeron
Landing now. https://codereview.chromium.org/2107833002/diff/1/src/compiler/store-store-elimination.cc File src/compiler/store-store-elimination.cc (right): https://codereview.chromium.org/2107833002/diff/1/src/compiler/store-store-elimination.cc#newcode210 src/compiler/store-store-elimination.cc:210: bool LeqTagged(FieldAccess access) { On 2016/06/28 21:30:55, ...
4 years, 5 months ago (2016-06-29 08:31:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107833002/20001
4 years, 5 months ago (2016-06-29 08:31:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 09:26:49 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 09:29:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2652812b642f39cdfbe91ca9e0ddfbebdb9d44f8
Cr-Commit-Position: refs/heads/master@{#37374}

Powered by Google App Engine
This is Rietveld 408576698