Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2099683002: [compiler] Enable store-store elimination by default in Turbofan. (Closed)

Created:
4 years, 6 months ago by bgeron
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Enable store-store elimination by default in Turbofan. BUG= Committed: https://crrev.com/bf5641f9baed9fa2e80b144927d1bc6f692b55ce Cr-Commit-Position: refs/heads/master@{#37380}

Patch Set 1 #

Patch Set 2 : test cl to debug on arm #

Patch Set 3 : Make dependent on CL that fixes SSEL on 32-bit archs. #

Patch Set 4 : (rebase to patch 2 of the CL this CL depends on) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/flag-definitions.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (7 generated)
bgeron
PTAL; as discussed.
4 years, 6 months ago (2016-06-24 11:45:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2099683002/1
4 years, 6 months ago (2016-06-24 11:48:39 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/3726) v8_linux_arm_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-24 12:06:39 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2107833002 Patch 20001). Please resolve the dependency and ...
4 years, 5 months ago (2016-06-29 08:32:32 UTC) #9
Jarin
lgtm
4 years, 5 months ago (2016-06-29 08:55:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099683002/60001
4 years, 5 months ago (2016-06-29 09:32:51 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-29 10:25:08 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 10:26:21 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bf5641f9baed9fa2e80b144927d1bc6f692b55ce
Cr-Commit-Position: refs/heads/master@{#37380}

Powered by Google App Engine
This is Rietveld 408576698