Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 210783002: Oilpan: Move Interpolation's hierarchy to oilpan's heap (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Oilpan: Move Interpolation's hierarchy to oilpan's heap This CL moves Interpolation's hierarchy and InterpolationRecord to oilpan's heap. I'll move other Interpolation objects in a follow-up CL. BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -70 lines) Patch
M Source/core/animation/Animation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStack.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/InertAnimation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InertAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolableValueTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/Interpolation.h View 4 chunks +17 lines, -9 lines 0 comments Download
M Source/core/animation/Interpolation.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/animation/InterpolationEffect.h View 1 chunk +16 lines, -11 lines 0 comments Download
M Source/core/animation/InterpolationEffect.cpp View 2 chunks +9 lines, -4 lines 0 comments Download
M Source/core/animation/InterpolationEffectTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
ok, now tests pass. PTAL.
6 years, 9 months ago (2014-03-25 07:05:59 UTC) #1
Mads Ager (chromium)
lgtm
6 years, 9 months ago (2014-03-25 07:16:04 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-25 07:21:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/210783002/1
6 years, 9 months ago (2014-03-25 07:21:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 08:00:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 08:00:15 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-25 08:33:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/210783002/1
6 years, 9 months ago (2014-03-25 08:33:18 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 08:33:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 169919

Powered by Google App Engine
This is Rietveld 408576698