Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analysis_server/lib/src/socket_server.dart

Issue 2107793002: Generalize DartSdkManager to support embedder SDKs (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/socket_server.dart
diff --git a/pkg/analysis_server/lib/src/socket_server.dart b/pkg/analysis_server/lib/src/socket_server.dart
index 380f3a85c42f3ae195ea0774fc8dd9bc0d9603e7..bce9dc82ab769cfc0e27c38538add46ecf83be4b 100644
--- a/pkg/analysis_server/lib/src/socket_server.dart
+++ b/pkg/analysis_server/lib/src/socket_server.dart
@@ -29,7 +29,7 @@ class SocketServer {
/**
* The function used to create a new SDK using the default SDK.
*/
- final SdkCreator defaultSdkCreator;
+ final DartSdkManager sdkManager;
final DirectoryBasedDartSdk defaultSdk;
final InstrumentationService instrumentationService;
@@ -51,7 +51,7 @@ class SocketServer {
SocketServer(
this.analysisServerOptions,
- this.defaultSdkCreator,
+ this.sdkManager,
this.defaultSdk,
this.instrumentationService,
this.serverPlugin,
@@ -97,7 +97,7 @@ class SocketServer {
index,
serverPlugin,
analysisServerOptions,
- defaultSdkCreator,
+ sdkManager,
instrumentationService,
fileResolverProvider: fileResolverProvider,
packageResolverProvider: packageResolverProvider,
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698