Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: src/compiler/simplified-operator-reducer.cc

Issue 2107783004: [turbofan] Disallow typing for change/checked operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@TurboFan_RepresentationSelection_Typer
Patch Set: ReferenceEqual foo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-operator-reducer.h ('k') | src/compiler/typer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/simplified-operator-reducer.cc
diff --git a/src/compiler/simplified-operator-reducer.cc b/src/compiler/simplified-operator-reducer.cc
index b9d5c268d180735d779af8e7141e466bb8a107ce..e9ce0d5a660776cd29af6c2d8f29dc9f787c5f7d 100644
--- a/src/compiler/simplified-operator-reducer.cc
+++ b/src/compiler/simplified-operator-reducer.cc
@@ -34,9 +34,7 @@ Decision DecideObjectIsSmi(Node* const input) {
SimplifiedOperatorReducer::SimplifiedOperatorReducer(Editor* editor,
JSGraph* jsgraph)
- : AdvancedReducer(editor),
- jsgraph_(jsgraph),
- type_cache_(TypeCache::Get()) {}
+ : AdvancedReducer(editor), jsgraph_(jsgraph) {}
SimplifiedOperatorReducer::~SimplifiedOperatorReducer() {}
@@ -162,41 +160,17 @@ Reduction SimplifiedOperatorReducer::Reduce(Node* node) {
if (m.HasValue()) return ReplaceNumber(std::fabs(m.Value()));
break;
}
- case IrOpcode::kNumberCeil:
- case IrOpcode::kNumberFloor:
- case IrOpcode::kNumberRound:
- case IrOpcode::kNumberTrunc: {
- Node* const input = NodeProperties::GetValueInput(node, 0);
- Type* const input_type = NodeProperties::GetType(input);
- if (input_type->Is(type_cache_.kIntegerOrMinusZeroOrNaN)) {
- return Replace(input);
- }
+ case IrOpcode::kReferenceEqual: {
+ HeapObjectBinopMatcher m(node);
+ if (m.left().node() == m.right().node()) return ReplaceBoolean(true);
break;
}
- case IrOpcode::kReferenceEqual:
- return ReduceReferenceEqual(node);
default:
break;
}
return NoChange();
}
-Reduction SimplifiedOperatorReducer::ReduceReferenceEqual(Node* node) {
- DCHECK_EQ(IrOpcode::kReferenceEqual, node->opcode());
- Node* const left = NodeProperties::GetValueInput(node, 0);
- Node* const right = NodeProperties::GetValueInput(node, 1);
- HeapObjectMatcher match_left(left);
- HeapObjectMatcher match_right(right);
- if (match_left.HasValue() && match_right.HasValue()) {
- if (match_left.Value().is_identical_to(match_right.Value())) {
- return Replace(jsgraph()->TrueConstant());
- } else {
- return Replace(jsgraph()->FalseConstant());
- }
- }
- return NoChange();
-}
-
Reduction SimplifiedOperatorReducer::Change(Node* node, const Operator* op,
Node* a) {
DCHECK_EQ(node->InputCount(), OperatorProperties::GetTotalInputCount(op));
« no previous file with comments | « src/compiler/simplified-operator-reducer.h ('k') | src/compiler/typer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698