Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2107753002:
Allow page interactions whilst the offline easter egg is inactive (Closed)
|
Created:
4 years, 5 months ago by edwardjung Modified:
4 years, 5 months ago Reviewers:
mmenke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow page interactions whilst the offline easter egg is inactive.
This fixes an issue where pull to refresh was not possible once the easter egg was activated.
BUG=623589
Committed: https://crrev.com/836d270fadcb4ec8ae20d3129ac3e674ec22765e
Cr-Commit-Position: refs/heads/master@{#402477}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Allow page interactions whilst the easter egg is inactive BUG=623589 ========== to ========== Allow page interactions whilst the easter egg is inactive. This fixes an issue where pull to refresh was not possible once the easter egg was activated. BUG=623589 ==========
edwardjung@chromium.org changed reviewers: + mmenke@chromium.org
Mmenke, a quick fix for the bug you raised.
https://codereview.chromium.org/2107753002/diff/1/components/neterror/resourc... File components/neterror/resources/offline.js (right): https://codereview.chromium.org/2107753002/diff/1/components/neterror/resourc... components/neterror/resources/offline.js:653: if (IS_MOBILE && this.activated) { If I'm following the code right, this means that you have to lose the game before you can reload?
On 2016/06/28 13:39:21, mmenke wrote: > https://codereview.chromium.org/2107753002/diff/1/components/neterror/resourc... > File components/neterror/resources/offline.js (right): > > https://codereview.chromium.org/2107753002/diff/1/components/neterror/resourc... > components/neterror/resources/offline.js:653: if (IS_MOBILE && this.activated) { > If I'm following the code right, this means that you have to lose the game > before you can reload? Yes, however, before the game has started, if you tap with intention to pull down, you can continue to do so whilst activating the game. Subsequent pull downs gestures do need the game to have stopped as otherwise most user's taps will also scroll the page.
On 2016/06/28 13:51:58, edwardjung wrote: > On 2016/06/28 13:39:21, mmenke wrote: > > > https://codereview.chromium.org/2107753002/diff/1/components/neterror/resourc... > > File components/neterror/resources/offline.js (right): > > > > > https://codereview.chromium.org/2107753002/diff/1/components/neterror/resourc... > > components/neterror/resources/offline.js:653: if (IS_MOBILE && this.activated) > { > > If I'm following the code right, this means that you have to lose the game > > before you can reload? > > Yes, however, before the game has started, if you tap with intention to pull > down, you can continue to do so whilst activating the game. Subsequent pull > downs gestures do need the game to have stopped as otherwise most user's taps > will also scroll the page. Thanks. LGTM!
Description was changed from ========== Allow page interactions whilst the easter egg is inactive. This fixes an issue where pull to refresh was not possible once the easter egg was activated. BUG=623589 ========== to ========== Allow page interactions whilst the offline easter egg is inactive. This fixes an issue where pull to refresh was not possible once the easter egg was activated. BUG=623589 ==========
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by edwardjung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow page interactions whilst the offline easter egg is inactive. This fixes an issue where pull to refresh was not possible once the easter egg was activated. BUG=623589 ========== to ========== Allow page interactions whilst the offline easter egg is inactive. This fixes an issue where pull to refresh was not possible once the easter egg was activated. BUG=623589 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Allow page interactions whilst the offline easter egg is inactive. This fixes an issue where pull to refresh was not possible once the easter egg was activated. BUG=623589 ========== to ========== Allow page interactions whilst the offline easter egg is inactive. This fixes an issue where pull to refresh was not possible once the easter egg was activated. BUG=623589 Committed: https://crrev.com/836d270fadcb4ec8ae20d3129ac3e674ec22765e Cr-Commit-Position: refs/heads/master@{#402477} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/836d270fadcb4ec8ae20d3129ac3e674ec22765e Cr-Commit-Position: refs/heads/master@{#402477} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
