components/neterror/resources/offline.js - Issue 2107753002: Allow page interactions whilst the offline easter egg is inactive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/neterror/resources/offline.js

Issue 2107753002: Allow page interactions whilst the offline easter egg is inactive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/neterror/resources/offline.js

diff --git a/components/neterror/resources/offline.js b/components/neterror/resources/offline.js

index 21bd28663501b1067115f1787391b51a846e9529..005f4f3ae20dc570369df092d783a9e5bfec0e13 100644

--- a/components/neterror/resources/offline.js

+++ b/components/neterror/resources/offline.js

@@ -650,7 +650,7 @@ Runner.prototype = {

onKeyDown: function(e) {

// Prevent native page scrolling whilst tapping on mobile.

- if (IS_MOBILE) {

+ if (IS_MOBILE && this.activated) {

mmenke 2016/06/28 13:39:21 If I'm following the code right, this means that y

e.preventDefault();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »