Issue 2107693002: [debug] fix return position computation for liveedit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2107693002: [debug] fix return position computation for liveedit. (Closed)

Created:
4 years, 5 months ago by Yang

Modified:
4 years, 5 months ago

Reviewers:
jgruber

CC:
v8-reviews_googlegroups.com, Yang

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[debug] fix return position computation for liveedit. R=jgruber@chromium.org Committed: https://crrev.com/4c6914293b0e4720ae22574cd4df15177f64f72a Cr-Commit-Position: refs/heads/master@{#37316}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	src/debug/debug.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107693002/1

4 years, 5 months ago (2016-06-28 07:35:13 UTC) #4

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 08:01:27 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4c6914293b0e4720ae22574cd4df15177f64f72a
Cr-Commit-Position: refs/heads/master@{#37316}