Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: src/debug/debug.cc

Issue 2107693002: [debug] fix return position computation for liveedit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index d68ca6bbf92b3bc7e3047826b1d1a98fbeaf1b96..8451ed595d2a40c855c16fa2f0ca3f0c4c512f82 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -67,7 +67,6 @@ BreakLocation::BreakLocation(Handle<DebugInfo> debug_info, DebugBreakType type,
type_(type),
position_(position),
statement_position_(statement_position) {
-#ifdef DEBUG
if (type == DEBUG_BREAK_SLOT_AT_RETURN) {
int return_position = 0;
SharedFunctionInfo* shared = debug_info->shared();
@@ -75,10 +74,10 @@ BreakLocation::BreakLocation(Handle<DebugInfo> debug_info, DebugBreakType type,
return_position =
std::max(shared->end_position() - shared->start_position() - 1, 0);
}
- CHECK_EQ(return_position, position);
- CHECK_EQ(return_position, statement_position);
+ // TODO(yangguo): find out why return position is wrong for liveedit.
+ position_ = return_position;
+ statement_position = return_position;
}
-#endif // DEBUG
}
BreakLocation::Iterator* BreakLocation::GetIterator(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698