Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2107583002: Change chooser action button to use grey and blue background (Closed)

Created:
4 years, 5 months ago by juncai
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change chooser action button to use grey and blue background Sometimes users are trying to tap "PAIR" on WebBluetooth chooser dialogs without selecting an item. This CL changes the button to use grey background when no item is selected and use blue background when an item is selected. This makes it easier to see if the button is faded out or not. I attached two screenshots of the chooser with grey and blue background button in the issue link. BUG=623117 Committed: https://crrev.com/ab04565a023ea70f5a4e424bef70bbb97336b40d Cr-Commit-Position: refs/heads/master@{#402346}

Patch Set 1 : changed chooser action button to use grey and blue background #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/android/java/res/layout/item_chooser_dialog.xml View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
juncai
Please take a look.
4 years, 5 months ago (2016-06-27 22:45:33 UTC) #4
Ted C
lgtm
4 years, 5 months ago (2016-06-27 22:57:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107583002/1
4 years, 5 months ago (2016-06-27 23:01:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 00:41:01 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 00:44:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab04565a023ea70f5a4e424bef70bbb97336b40d
Cr-Commit-Position: refs/heads/master@{#402346}

Powered by Google App Engine
This is Rietveld 408576698