chrome/browser/chrome_browser_main.cc - Issue 2107493002: Offer user to send feedback from profile error dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sky's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/history/android/android_provider_backend_unittest.cc » ('j') | sql/error_delegate_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index aac3599c8dbd5968bce77d00d09f91e9845a5d0a..21c2596e1f4cd7388e30d1511ec347a667dff29f 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -443,7 +443,11 @@ Profile* CreatePrimaryProfile(const content::MainFunctionParams& parameters,

PROFILE_ERROR_CREATE_FAILURE_SPECIFIED :

PROFILE_ERROR_CREATE_FAILURE_ALL;

- ShowProfileErrorDialog(error_type, IDS_COULDNT_STARTUP_PROFILE_ERROR);

+ // TODO(lwchkg): What diagnostics do you want to include in the feedback

+ // report when an error occurs?

+ ShowProfileErrorDialog(error_type,

+ IDS_COULDNT_STARTUP_PROFILE_ERROR,

+ std::string());

return nullptr;

}

#endif // defined(OS_CHROMEOS) || defined(OS_ANDROID)

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/history/android/android_provider_backend_unittest.cc » ('j') | sql/error_delegate_util.h » ('J')