Offer user to send feedback from profile error dialog

sql/error_delegate_util.h

Index: sql/error_delegate_util.h
diff --git a/sql/error_delegate_util.h b/sql/error_delegate_util.h
index 0c67c07ec7835b83303f9adc306cbe982dc2ed7a..324977fd8352bfc52b88cebcf829735b3b74bee2 100644
--- a/sql/error_delegate_util.h
+++ b/sql/error_delegate_util.h
@@ -5,6 +5,9 @@
 #ifndef SQL_ERROR_DELEGATE_UTIL_H_
 #define SQL_ERROR_DELEGATE_UTIL_H_
 
+#include <string>
+
+#include "base/files/file_path.h"
 #include "sql/sql_export.h"
 
 namespace sql {
@@ -13,6 +16,16 @@ namespace sql {
 // |error|.
 SQL_EXPORT bool IsErrorCatastrophic(int error);
 
+// Appends diagnostic info of the given |corrupted_file_path| to the given
+// |diagnostics|. The appended info are not localized as it's meant to be added
+// to feedback reports and used by developers.
+// Also the full file path is not appended as it might contain some PII. Instead
+// only the last two components of the path are appended to distinguish between
+// default and user profiles.
+SQL_EXPORT void AppendCorruptFileInfoToDiagnostics(

[sky, 2016/08/03 23:36:18]

Sorry, one question, can you clarify why this has to take std::string* and not
return a string? If the caller wants to append they can always do that, e.g.:
existing += AppendCorruptFileInfoToDiagnostics(...);

Not taking an existing string makes for easier to understand function, and more
natural api.

[afakhry, 2016/08/04 18:01:31]

Done.

+    const base::FilePath& corrupted_file_path,
+    std::string* diagnostics);
+
 }  // namespace sql
 
 #endif  // SQL_ERROR_DELEGATE_UTIL_H_