Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2292)

Unified Diff: chrome/browser/ui/profile_error_dialog.h

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Yet more compile errors Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/profile_error_dialog.h
diff --git a/chrome/browser/ui/profile_error_dialog.h b/chrome/browser/ui/profile_error_dialog.h
index eec7ba97c96df6c802ab2e0e2218172992b32856..7ae8c002112f1a2b238dfde6397ae67dc44e7b8a 100644
--- a/chrome/browser/ui/profile_error_dialog.h
+++ b/chrome/browser/ui/profile_error_dialog.h
@@ -5,6 +5,13 @@
#ifndef CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
#define CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
+#include "sql/db_diagnostic_map.h"
+#include "sql/init_status.h"
Lei Zhang 2016/07/09 01:04:47 Not needed here?
afakhry 2016/07/11 16:47:45 Done.
+
+namespace base {
+class FilePath;
Lei Zhang 2016/07/09 01:04:47 Not needed?
afakhry 2016/07/11 16:47:45 Yup, forgot to remove it. Done.
+} // namespace base
+
// Be very careful while modifying this enum. Do NOT remove any elements from
// this enum. If you need to add one, add them to the end, right before
// PROFILE_ERROR_END. PROFILE_ERROR_END should ALWAYS be the last element in
@@ -22,11 +29,15 @@ enum ProfileErrorType {
};
// Shows an error dialog corresponding to the inability to open some portion of
-// the profile. |message_id| is a string id corresponding to the message to
-// show. The ProfileErrorType needs to correspond to one of the profile error
-// types in the enum above. If your use case doesn't fit any of the ones listed
-// above, please add your type to the enum and modify the enum
-// definition in tools/metrics/histograms/histograms.xml accordingly.
-void ShowProfileErrorDialog(ProfileErrorType type, int message_id);
+// the profile. |diagnostics| contains diagnostic information about the database
Lei Zhang 2016/07/09 01:04:47 Maybe start a new line for each param. It's a long
afakhry 2016/07/11 16:47:45 Done.
+// file that might have caused a profile error. |message_id| is a string id
+// corresponding to the message to show. The ProfileErrorType needs to
+// correspond to one of the profile error types in the enum above. If your use
+// case doesn't fit any of the ones listed above, please add your type to the
+// enum and modify the enum definition in
+// tools/metrics/histograms/histograms.xml accordingly.
+void ShowProfileErrorDialog(ProfileErrorType type,
+ int message_id,
+ const sql::DatabaseDiagnosticMap& diagnostics);
#endif // CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_

Powered by Google App Engine
This is Rietveld 408576698