Offer user to send feedback from profile error dialog

components/history/core/browser/history_backend.cc

Index: components/history/core/browser/history_backend.cc
diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc
index 42732d85f1fe31ec625d0eedd10747b901a47a50..68c8360e53c767d347f3e8bd335dcbfb09554e0b 100644
--- a/components/history/core/browser/history_backend.cc
+++ b/components/history/core/browser/history_backend.cc
@@ -657,7 +657,7 @@ void HistoryBackend::InitImpl(
     case sql::INIT_OK:
       break;
     case sql::INIT_TOO_NEW:
-      delegate_->NotifyProfileError(status);
+      delegate_->NotifyProfileError(history_name, status);
       db_.reset();
       return;
     case sql::INIT_FAILURE: {
@@ -669,7 +669,7 @@ void HistoryBackend::InitImpl(
       if (kill_db)
         KillHistoryDatabase();
       UMA_HISTOGRAM_BOOLEAN("History.AttemptedToFixProfileError", kill_db);
-      delegate_->NotifyProfileError(status);
+      delegate_->NotifyProfileError(history_name, status);

[Scott Hess - ex-Googler, 2016/06/29 05:13:48]

Note that if the db is open, it may hold locks which will prevent a generic
diagnostic from working.  Likewise above.

[afakhry, 2016/06/29 18:57:18]

So do you suggest moving these calls elsewhere? Perhaps after the DB has been
killed?

[Scott Hess - ex-Googler, 2016/06/29 19:17:27]

Depends on what you're going to do.  If NotifyProfileError() needs to run before
reset() on the next line, and NotifyProfileError() might want to open the
database to inspect it, then you need to explicitly call Close().  But if it's
going to be entirely independent with no way to refer back to this code, then
you could just put the reset() above the notify call.

       db_.reset();
       return;
     }