Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2107443002:
[heap] Optimize ArrayBuffer tracking (Closed)
|
Created:
4 years, 5 months ago by Michael Lippautz Modified:
4 years, 5 months ago Reviewers:
ulan CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Optimize ArrayBuffer tracking
With the current approach we only need to track using an unordered set as we can
still access the backing store pointer and length by the time we free the
backing store.
BUG=chromium:619491, chromium:611688
LOG=N
R=ulan@chromium.org
Committed: https://crrev.com/8d2ae27808f047ca8b8f90e63a9c8735321d2ad0
Cr-Commit-Position: refs/heads/master@{#37318}
Patch Set 1 #Patch Set 2 #Patch Set 3 #Patch Set 4 : Avoid eager rehashing #Patch Set 5 : Remove rehashing logic #
Messages
Total messages: 33 (20 generated)
Description was changed from ========== [heap] ArrayBuffer tracking optimization Track using a set as we can still access all interesting properties from the object. BUG= ========== to ========== [heap] ArrayBuffer tracking optimization Track using a set as we can still access all interesting properties from the object. BUG=chromium:619491 LOG=N ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] ArrayBuffer tracking optimization Track using a set as we can still access all interesting properties from the object. BUG=chromium:619491 LOG=N ========== to ========== [heap] ArrayBuffer tracking optimization With the current approach we only need to track using a set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491 LOG=N ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [heap] ArrayBuffer tracking optimization With the current approach we only need to track using a set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491 LOG=N ========== to ========== [heap] ArrayBuffer tracking optimization With the current approach we only need to track using a set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491, chromium:611688 LOG=N ==========
Description was changed from ========== [heap] ArrayBuffer tracking optimization With the current approach we only need to track using a set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491, chromium:611688 LOG=N ========== to ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using a set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491, chromium:611688 LOG=N ==========
Description was changed from ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using a set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491, chromium:611688 LOG=N ========== to ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491, chromium:611688 LOG=N ==========
Description was changed from ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length upon free'ing. BUG=chromium:619491, chromium:611688 LOG=N ========== to ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N ==========
Description was changed from ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N ========== to ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N ==========
Description was changed from ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N ========== to ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N R=ulan@chromium.org ==========
mlippautz@chromium.org changed reviewers: + ulan@chromium.org
lgtm
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2107443002/#ps80001 (title: "Remove rehashing logic")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N R=ulan@chromium.org ========== to ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N R=ulan@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N R=ulan@chromium.org ========== to ========== [heap] Optimize ArrayBuffer tracking With the current approach we only need to track using an unordered set as we can still access the backing store pointer and length by the time we free the backing store. BUG=chromium:619491, chromium:611688 LOG=N R=ulan@chromium.org Committed: https://crrev.com/8d2ae27808f047ca8b8f90e63a9c8735321d2ad0 Cr-Commit-Position: refs/heads/master@{#37318} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/8d2ae27808f047ca8b8f90e63a9c8735321d2ad0 Cr-Commit-Position: refs/heads/master@{#37318}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2105273002/ by mlippautz@chromium.org. The reason for reverting is: Seems to break GPU bots. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
