Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2107423003: Revert of [gn] Switch custom snapsot bot to gn (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Switch custom snapsot bot to gn (patchset #2 id:20001 of https://codereview.chromium.org/2113583002/ ) Reason for revert: Breaks... Original issue's description: > [gn] Switch custom snapsot bot to gn > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 > Cr-Commit-Position: refs/heads/master@{#37431} TBR=yangguo@chromium.org,vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/33ceb9e5d6a38178d7abd7eb5ac46b6393305c96 Cr-Commit-Position: refs/heads/master@{#37434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M BUILD.gn View 3 chunks +0 lines, -10 lines 0 comments Download
M infra/mb/mb_config.pyl View 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [gn] Switch custom snapsot bot to gn
4 years, 5 months ago (2016-06-30 11:13:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107423003/1
4 years, 5 months ago (2016-06-30 11:13:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 11:13:56 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 11:14:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33ceb9e5d6a38178d7abd7eb5ac46b6393305c96
Cr-Commit-Position: refs/heads/master@{#37434}

Powered by Google App Engine
This is Rietveld 408576698