Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: BUILD.gn

Issue 2107423003: Revert of [gn] Switch custom snapsot bot to gn (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index e6384c6290dca291314163def329d108c65bd123..466fac63cce2be51c68e85965eb925167010be55 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -27,9 +27,6 @@
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
v8_imminent_deprecation_warnings = false
-
- # Embeds the given script into the snapshot.
- v8_embed_script = ""
# Sets -dENABLE_DISASSEMBLER.
v8_enable_disassembler = false
@@ -592,8 +589,6 @@
script = "tools/run.py"
- sources = []
-
outputs = [
"$target_gen_dir/snapshot.cc",
]
@@ -619,11 +614,6 @@
"--startup_blob",
rebase_path("$root_out_dir/snapshot_blob.bin", root_build_dir),
]
- }
-
- if (v8_embed_script != "") {
- sources += [ v8_embed_script ]
- args += [ rebase_path(v8_embed_script, root_build_dir) ]
}
}
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698