Issue 2107373003: Some cleanup for become.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2107373003: Some cleanup for become. (Closed)

Created:
4 years, 5 months ago by rmacnak

Modified:
4 years, 5 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Some cleanup for become. - Remove forced GC (probably predates use of the write barrier). - Remove some paranoid asserts to avoid 2 heap walks in debug mode. Debug mode become on dart2js identity reload: 600-870ms -> 200-400ms R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/7219cfdcac2a7546ad2b23f463425cd76f5a2b4d

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -48 lines)			Patch
	M	runtime/vm/become.cc	View		3 chunks	+6 lines, -48 lines	0 comments	Download
	M	runtime/vm/isolate_reload.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Cutch

LGTM after confirming that dart2js runs to completion (with background compiler and osr off).

4 years, 5 months ago (2016-06-30 21:08:38 UTC) #3

rmacnak

4 years, 5 months ago (2016-06-30 22:43:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7219cfdcac2a7546ad2b23f463425cd76f5a2b4d (presubmit successful).