Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Side by Side Diff: runtime/vm/isolate_reload.cc

Issue 2107373003: Some cleanup for become. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/become.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/isolate_reload.h" 5 #include "vm/isolate_reload.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/code_generator.h" 8 #include "vm/code_generator.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_api_impl.h" 10 #include "vm/dart_api_impl.h"
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 void IsolateReloadContext::Rollback() { 613 void IsolateReloadContext::Rollback() {
614 I->object_store()->set_compile_time_constants( 614 I->object_store()->set_compile_time_constants(
615 Array::Handle(compile_time_constants_)); 615 Array::Handle(compile_time_constants_));
616 RollbackClasses(); 616 RollbackClasses();
617 RollbackLibraries(); 617 RollbackLibraries();
618 } 618 }
619 619
620 620
621 #ifdef DEBUG 621 #ifdef DEBUG
622 void IsolateReloadContext::VerifyMaps() { 622 void IsolateReloadContext::VerifyMaps() {
623 TIMELINE_SCOPE(VerifyMaps);
623 Class& cls = Class::Handle(); 624 Class& cls = Class::Handle();
624 Class& new_cls = Class::Handle(); 625 Class& new_cls = Class::Handle();
625 Class& cls2 = Class::Handle(); 626 Class& cls2 = Class::Handle();
626 Class& new_cls2 = Class::Handle(); 627 Class& new_cls2 = Class::Handle();
627 628
628 // Verify that two old classes aren't both mapped to the same new 629 // Verify that two old classes aren't both mapped to the same new
629 // class. This could happen is the IsSameClass function is broken. 630 // class. This could happen is the IsSameClass function is broken.
630 UnorderedHashMap<ClassMapTraits> class_map(class_map_storage_); 631 UnorderedHashMap<ClassMapTraits> class_map(class_map_storage_);
631 { 632 {
632 UnorderedHashMap<ClassMapTraits>::Iterator it(&class_map); 633 UnorderedHashMap<ClassMapTraits>::Iterator it(&class_map);
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
1158 ASSERT(!super_cls.IsNull()); 1159 ASSERT(!super_cls.IsNull());
1159 super_cls.AddDirectSubclass(cls); 1160 super_cls.AddDirectSubclass(cls);
1160 } 1161 }
1161 } 1162 }
1162 } 1163 }
1163 } 1164 }
1164 1165
1165 #endif // !PRODUCT 1166 #endif // !PRODUCT
1166 1167
1167 } // namespace dart 1168 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/become.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698