QUIC - expand server push test coverage and fix recent regression.

QUIC - expand server push test coverage and fix recent regression.

Fix regression after https://codereview.chromium.org/1877703002.

Add server push test to quic_network_transaction_unittest.cc that
without the above fix catches the regression.

R=rch@chromium.org
BUG=622043
Committed: https://crrev.com/769733cda1cf53c42ded5b8610b80e107a72771f
Cr-Commit-Position: refs/heads/master@{#403040}

[Buck, 2016-06-29 22:31:02]

The CQ bit was checked by ckrasic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 22:33:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-06-29 22:57:11]

lgtm

NICE!

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:337: QuicPacketNumber num,
nit: num -> packet_number

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:341: QuicTestPacketMaker* maker) {
I think you can drop the |maker| arg here, since this just calls client_maker_,
right?

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:2295:
mock_quic_data.AddWrite(ConstructClientAckPacket(3, 4, 3, 1, &client_maker_));
number, number, number, number .. . LGTM! :)

[Buck, 2016-06-29 23:16:03]

The CQ bit was checked by ckrasic@chromium.org to run a CQ dry run

[Buck, 2016-06-29 23:16:48]

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:337: QuicPacketNumber num,
On 2016/06/29 22:57:10, Ryan Hamilton wrote:
> nit: num -> packet_number

Done.

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:341: QuicTestPacketMaker* maker) {
On 2016/06/29 22:57:11, Ryan Hamilton wrote:
> I think you can drop the |maker| arg here, since this just calls
client_maker_,
> right?

Done.

https://codereview.chromium.org/2107353003/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:2295:
mock_quic_data.AddWrite(ConstructClientAckPacket(3, 4, 3, 1, &client_maker_));
On 2016/06/29 22:57:11, Ryan Hamilton wrote:
> number, number, number, number .. . LGTM! :)

Done.

[commit-bot: I haz the power, 2016-06-29 23:20:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 00:30:11]

Dry run: This issue passed the CQ dry run.

[Buck, 2016-06-30 00:35:41]

The CQ bit was checked by ckrasic@chromium.org

[Buck, 2016-06-30 00:35:41]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2107353003/#ps20001
(title: "QUIC - expand server push test coverage and fix recent regression.")

[commit-bot: I haz the power, 2016-06-30 00:36:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:42:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 00:44:04]

Description was changed from

==========
QUIC - expand server push test coverage and fix recent regression.

Fix regression after https://codereview.chromium.org/1877703002.

Add server push test to quic_network_transaction_unittest.cc that
without the above fix catches the regression.

R=rch@chromium.org
BUG=622043
==========

to

==========
QUIC - expand server push test coverage and fix recent regression.

Fix regression after https://codereview.chromium.org/1877703002.

Add server push test to quic_network_transaction_unittest.cc that
without the above fix catches the regression.

R=rch@chromium.org
BUG=622043

Committed: https://crrev.com/769733cda1cf53c42ded5b8610b80e107a72771f
Cr-Commit-Position: refs/heads/master@{#403040}
==========

[commit-bot: I haz the power, 2016-06-30 00:44:05]

Patchset 2 (id:??) landed as
https://crrev.com/769733cda1cf53c42ded5b8610b80e107a72771f
Cr-Commit-Position: refs/heads/master@{#403040}