Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1877703002: Landing Recent QUIC changes until 4/8/2016 17:17 UTC (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 4/8/2016 17:17 UTC relnote: (test-only) Change the time QuicTestClient accreted num_responses_; Move ++num_responses_ up to make counting work for multi requests and response case. Merge internal change: 119384036 https://codereview.chromium.org/1871903004/ relnote: Implements OnHeaderFrameStart and OnHeaderFrameEnd in QuicHeadersStream. Not used in production. Not protected. A new helper data structure, QuicHeaderList, is used to store an ordered list of header pairs for later interpretation. Instead of SPDY3-encoded header block bytes, a QuicHeaderList is passed through the various QUIC stream APIs. Merge internal change: 119198371 https://codereview.chromium.org/1870833005/ relnote: deprecate --quic_log_received_parameters Merge internal change: 119188441 https://codereview.chromium.org/1871953003/ relnote: n/a (removing outdated include) Removing an outdated include. Merge internal change: 119182848 https://codereview.chromium.org/1873573005/ relnote: Update QUIC code to match Chromium change. Remove log message. Merge internal change: 119052747 https://codereview.chromium.org/1873883002/ relnote: Add QUIC connection option DHDT to disable HPACK dynamic table. Guarded by quic_disable_hpack_dynamic_table. Will be used in a Finch trial to gather data about HPACK compression efficiency: how much of HPACK's efficiency derives from the dynamic table, as opposed to other parts of HPACK such as the static table and huffman coding? If it is very low then next step would be to: o with dynamic table disabled, disable the monolithic header stream, to gather data about whether reducing HOL improves other metrics. o if results are positive, it has the advantage of maintaining (restricted) conformance to the HPACK spec. Otherwise, some (non-complient) extensions or modifications to HPACK might be necessary to reduce eliminate headers HOL blocking. o one idea involve maintining a small number of separate HPACK contexts, to ensure that dynamic reference only occur to older entries that are free of HOL blocking potential. Merge internal change: 118999202 https://codereview.chromium.org/1865803007/ relnote: Deprecate --quic_auto_tune_receive_window. Change code to enable receive buffer flow control auto tuning on server side, with an initial window size of 32KB for streams, and 48KB for the connection. - remove auto-tuning related connection option tags. - remove connection option code that was used to configure auto-tuning under the experiment. Merge internal change: 118983961 https://codereview.chromium.org/1873673002/ relnote: add connection option "SPSH" to indicate whether client wants to do server push or not, which is disabled by default on server. Move "SPSH" negotiation into shared code. Merge internal change: 118974770 https://codereview.chromium.org/1874613002/ BUG= Committed: https://crrev.com/6a31ee36d65f80ca2626c8b629550eb4af1d851e Cr-Commit-Position: refs/heads/master@{#386457}

Patch Set 1 #

Patch Set 2 : git sync #

Patch Set 3 : git cl format net #

Total comments: 3

Patch Set 4 : add empty lines after license #

Patch Set 5 : git sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -246 lines) Patch
M net/net.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 3 chunks +4 lines, -14 lines 0 comments Download
M net/quic/crypto/proof_test.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M net/quic/quic_flags.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 2 chunks +0 lines, -112 lines 0 comments Download
A net/quic/quic_header_list.h View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A net/quic/quic_header_list.cc View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A net/quic/quic_header_list_test.cc View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.h View 4 chunks +12 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 2 5 chunks +46 lines, -5 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +1 line, -58 lines 0 comments Download
M net/quic/quic_spdy_session.h View 4 chunks +19 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_session.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream.h View 7 chunks +28 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 5 chunks +71 lines, -1 line 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 2 chunks +33 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/spdy_utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/spdy_utils.cc View 1 2 2 chunks +50 lines, -0 lines 0 comments Download
M net/spdy/spdy_headers_handler_interface.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 10 chunks +13 lines, -20 lines 0 comments Download
M net/tools/quic/quic_server_session_base.h View 3 chunks +8 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_base.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Zhongyi Shi
4 years, 8 months ago (2016-04-11 04:42:07 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/1877703002/diff/40001/net/quic/quic_header_list.cc File net/quic/quic_header_list.cc (right): https://codereview.chromium.org/1877703002/diff/40001/net/quic/quic_header_list.cc#newcode4 net/quic/quic_header_list.cc:4: #include "net/quic/quic_header_list.h" please add blank line between line ...
4 years, 8 months ago (2016-04-11 18:22:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877703002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877703002/80001
4 years, 8 months ago (2016-04-11 18:33:51 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-11 20:18:15 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:19:57 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6a31ee36d65f80ca2626c8b629550eb4af1d851e
Cr-Commit-Position: refs/heads/master@{#386457}

Powered by Google App Engine
This is Rietveld 408576698