third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp - Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename the method in TreeScope class Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGResources.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp b/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

index d4fd2509f80728601384d0f033abf2eb699f8b15..b8623654ed608e9d0c6174fcdd4bb6ca5d11107b 100644

--- a/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

@@ -77,7 +77,7 @@ SVGFilterElement* ReferenceFilterBuilder::resolveFilterReference(const Reference

if (!filter) {

// Although we did not find the referenced filter, it might exist later

// in the document.

- treeScope->document().accessSVGExtensions().addPendingResource(filterOperation.fragment(), &element);

+ treeScope->accessSVGTreeScopedResources().addPendingResource(filterOperation.fragment(), &element);

return nullptr;

}