Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp

Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename the method in TreeScope class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Adobe Systems Inc. All rights reserved. 2 * Copyright (C) 2013 Adobe Systems Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * Copyright (C) 2011 Apple Inc. All rights reserved. 4 * Copyright (C) 2011 Apple Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 } 70 }
71 71
72 if (!treeScope) 72 if (!treeScope)
73 return nullptr; 73 return nullptr;
74 74
75 Element* filter = treeScope->getElementById(filterOperation.fragment()); 75 Element* filter = treeScope->getElementById(filterOperation.fragment());
76 76
77 if (!filter) { 77 if (!filter) {
78 // Although we did not find the referenced filter, it might exist later 78 // Although we did not find the referenced filter, it might exist later
79 // in the document. 79 // in the document.
80 treeScope->document().accessSVGExtensions().addPendingResource(filterOpe ration.fragment(), &element); 80 treeScope->accessSVGTreeScopedResources().addPendingResource(filterOpera tion.fragment(), &element);
81 return nullptr; 81 return nullptr;
82 } 82 }
83 83
84 if (!isSVGFilterElement(*filter)) 84 if (!isSVGFilterElement(*filter))
85 return nullptr; 85 return nullptr;
86 86
87 return toSVGFilterElement(filter); 87 return toSVGFilterElement(filter);
88 } 88 }
89 89
90 } // namespace blink 90 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698