Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2107143003: Revert of Make RenderProcessHost/RenderThread use MojoChildConnection/MojoShellConnection (Closed)

Created:
4 years, 5 months ago by tommycli
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rph2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make RenderProcessHost/RenderThread use MojoChildConnection/MojoShellConnection (patchset #5 id:80001 of https://codereview.chromium.org/2100693002/ ) Reason for revert: Speculatively reverting because this may have broken Dr. Memory bots. First breaking build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/11065 Bot: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(DrMemory%20full)%20(2) Original issue's description: > Make RenderProcessHost/RenderThread use MojoChildConnection/MojoShellConnection > > Extracted from: https://codereview.chromium.org/2096643002/ > > TBR=rockot@chromium.org > BUG= > > Committed: https://crrev.com/b4e2536de302ecbc29ad7a40fc124e15e7c74e77 > Cr-Commit-Position: refs/heads/master@{#402225} TBR=rockot@chromium.org,ben@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -178 lines) Patch
M content/browser/mojo/mojo_child_connection.h View 2 chunks +0 lines, -13 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 10 chunks +32 lines, -39 lines 0 comments Download
M content/child/child_thread_impl.h View 6 chunks +1 line, -14 lines 0 comments Download
M content/child/child_thread_impl.cc View 5 chunks +12 lines, -45 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 3 chunks +1 line, -5 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 2 chunks +1 line, -33 lines 0 comments Download
M content/public/child/child_thread.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M services/shell/public/cpp/connection.h View 2 chunks +1 line, -1 line 0 comments Download
M services/shell/public/cpp/interface_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/public/cpp/lib/interface_provider.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tommycli
Created Revert of Make RenderProcessHost/RenderThread use MojoChildConnection/MojoShellConnection
4 years, 5 months ago (2016-06-29 19:38:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107143003/1
4 years, 5 months ago (2016-06-29 19:39:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/89276) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 5 months ago (2016-06-29 19:47:27 UTC) #5
Ken Rockot(use gerrit already)
On 2016/06/29 at 19:39:09, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 5 months ago (2016-06-29 19:48:15 UTC) #6
Ken Rockot(use gerrit already)
On 2016/06/29 at 19:48:15, Ken Rockot wrote: > On 2016/06/29 at 19:39:09, commit-bot wrote: > ...
4 years, 5 months ago (2016-06-29 19:48:40 UTC) #7
tommycli
4 years, 5 months ago (2016-06-29 20:32:04 UTC) #8
On 2016/06/29 19:48:40, Ken Rockot wrote:
> On 2016/06/29 at 19:48:15, Ken Rockot wrote:
> > On 2016/06/29 at 19:39:09, commit-bot wrote:
> > > CQ is trying da patch. Follow status at
> > >  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > 
> > It's going to be very hard to revert this as several large dependent CLs
have
> landed since
> 
> Fix is WIP

Sounds good. Feel free to msg me once the fix is ready.

Powered by Google App Engine
This is Rietveld 408576698